jonas-schievink/rubble

Don't give up when missing the initial transmit window

Open

#77 创建于 2019年9月28日

在 GitHub 查看
 (0 评论) (2 反应) (0 负责人)Rust (403 star) (58 fork)user submission
area: link layergood first issuestatus: needs codetype: bug

描述

Currently the link layer will abort the connection when it does not receive the initial connect event:

https://github.com/jonas-schievink/rubble/blob/0c219f5fd1ef24cc6ca6f6e1edb02556e5fdd64f/rubble/src/link/connection.rs#L338-L345

This shouldn't happen. Instead, we should do what the comment suggests (and check it against the spec).

The effect of this bug is that establishing a connection can spuriously fail, so this is a reliability issue.

贡献者指南

技术栈
rust
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Basic understanding of RustFamiliarity with BLE connection establishment
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue points to lines 338-345 in connection.rs (https://github.com/jonas schievink/rubble/blob/0c219f5fd1ef24cc6ca6f6e1edb02556e5fdd64f/rubble/src/link/connection.rs#L338 L345) where the code aborts on missing initial transmit window. The fix should implement the comment's suggestion and check against the Bluetooth specification to properly handle this scenario without aborting. Reviewing the BLE core spec and similar implementations would be necessary to determine the correct behavior.