jonas-schievink/rubble

Only reply to LL_VERSION_IND once

Open

#49 创建于 2019年4月23日

在 GitHub 查看
 (0 评论) (1 反应) (0 负责人)Rust (403 star) (58 fork)user submission
area: link layergood first issuestatus: needs codetype: bug

描述

Either master or slave may send the LL_VERSION_IND LL Control PDU, and both will respond to it. According to the spec, you're supposed to keep track of whether you've already sent this and ignore the PDU in that case. We currently rely on the master to implement this correctly, since we'd otherwise end up in an endless loop.

To fix this, we need to add another bool to the real-time LinkLayer state to track whether we've sent this already. Eventually we should collapse all the bool flags into a single byte storing them as bitflags.

贡献者指南

技术栈
rust
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Rust programmingBLE protocol basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Locate the LinkLayer struct in the real time state (likely in rubble/src/link/link layer.rs or similar). Add a bool field to track whether LL VERSION IND has been sent. In the handler for LL VERSION IND PDU reception, check this flag and ignore if already sent, otherwise respond and set the flag. Ensure master/slave logic is respected. Consider eventual refactoring of bool flags into bitflags as noted.