jlfwong/speedscope

Support trailing whitespace & floating point values with Brendan Gregg collapsed stack format

Open

#157 创建于 2018年9月5日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)TypeScript (4,040 star) (181 fork)batch import
feature requesthelp wanted

描述

So I have some custom tool that generates data in a output similar to Brendan Gregg's stack format, that works with flamegraph.pl, but is throwing issues with my custom file.

I found there were a few different issues in my file:

  • a trailing newline in the file causing an error
  • my values weren't integers
  • some of my values were negative

Not sure if we could raise a better error message, for those?

Maybe it'd also be useful mentioning that in the docs, I am happy to make a PR, if there is a way to do that in docs?

贡献者指南

技术栈
typescript
领域
performance
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Basic understanding of TypeScriptFamiliarity with flamegraph profiling
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
The issue requests support for trailing whitespace, floating point, and negative values in the collapsed stack format parser. Investigate the parser code likely in files related to importing Brendan Gregg's format, such as `src/import/`. Look for where the format is parsed and how values are handled (e.g., integer parsing). Improve error messages for invalid values and update documentation accordingly. Check if there are existing tests for this format.