jieter/django-tables2

Default value not respected on export

开放

#710 创建于 2019年10月30日

 (1 条评论) (0 个反应) (0 位负责人)Python (443 个派生)batch import
Help wanteddocs

仓库指标

星标
 (2,012 个星标)
PR 合并指标
 (30 天内没有已合并 PR)

描述

I use the default value heavily in my tables, but noticed that default is not respected when I export tables.

It's the following code in django_tables2/rows.py

    def get_cell_value(self, name):
        """
        Returns the final rendered value (excluding any html) for a cell in the
        row, given the name of a column.
        """
        return self._get_and_render_with(
            self.table.columns[name], render_func=self._call_value, default=None
        )

As you can see, default=None is passed to get_and_render_with, effectively ignoring the default value.

Is there a reason for this? If there is, should we document it? Happy to contribute.

Thanks for the great library.

贡献者指南