jetty/jetty.project

Why there is no Regex Support for excludeList of nonProxyHost

Open

#8,329 创建于 2022年7月22日

在 GitHub 查看
 (10 评论) (0 反应) (1 负责人)Java (3,701 star) (1,913 fork)batch import
EnhancementHelp Wanted

描述

Code at line below should be enhanced: https://github.com/eclipse/jetty.project/blob/8102378e2d24b8117ed3a545c7579f79d35fc45a/jetty-client/src/main/java/org/eclipse/jetty/client/ProxyConfiguration.java#L180

Generally nonProxyHosts gets defined with wildcards like *.abc.com|*.svc.local etc.. so .equals doesn't help ! And apparently Jetty Client doesn't have any support for wildcard list of nonProxyHosts !!

PS: reactor-netty handles it pretty well, refer below: https://github.com/reactor/reactor-netty/blob/main/reactor-netty-core/src/main/java/reactor/netty/transport/ProxyProvider.java#L310

贡献者指南

技术栈
java
领域
backendapi
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
needs maintainer response
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaHTTP proxy concepts
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
The issue requests adding regex/wildcard support for nonProxyHosts in Jetty Client. The file to modify is ProxyConfiguration.java (line 180). Currently, it uses .equals() which fails for wildcard patterns like *.abc.com. A solution could implement pattern matching similar to reactor netty's ProxyProvider. Review the linked reactor netty code for reference. Discuss with maintainers about the desired pattern syntax and compatibility.