jetty/jetty.project

Review RolloverFileOutputStream locking

开放

#5,092 创建于 2020年7月29日

 (6 条评论) (0 个反应) (0 位负责人)Java (1,913 个派生)batch import
Help WantedLow PriorityPinned

仓库指标

星标
 (3,701 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Spawned by #5083.

Jetty version 9.4.x

Description RolloverFileOutputStream locking should be improved/removed.

Currently it locks on a class lock for no reasons, since __rollover is only ever written in the constructor (and thus could be final).

There should be some synchronization between the writes and the scheduled task (so that the file can be swapped without losing log lines), but the class locks seem unnecessary.

贡献者指南