jestjs/jest

Use cross browser stack trace utils

Open

#10,023 创建于 2020年5月11日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)TypeScript (45,361 star) (6,653 fork)batch import
:rocket: Feature RequestHelp WantedPinned

描述

🚀 Feature Proposal

It'd be awesome and fairly simple (I hope) to swap out stack-utils for https://github.com/stacktracejs/error-stack-parser which would give you the same metadata about stacks but work for non v8 stack traces

Motivation

We want to use jest-message-util to format errors from multiple browsers

Pitch

We are using a lot of jest in https://github.com/4Catalyzer/karma-jest which is a multi-browser environment via karma. Jest's excellent error formatting utils from jest-message-util work great (after mapping browser stacks to correct ones via source maps), but the formatting utils assume V8 based stack traces, which means FF and safari traces don't get nicely printed and call-site files are incorrectly parsed. This is due to some bad regexs and stack-utils which is designed for node.

If this seems like a good idea i can problem send a PR for it

贡献者指南

技术栈
typescriptjavascriptnodejs
领域
testing
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
needs maintainer response
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Understanding of stack tracesFamiliarity with jest message utilBasic regex knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Start by examining the jest message util source code, specifically how it parses stack traces using stack utils. Compare the API of error stack parser (https://github.com/stacktracejs/error stack parser) and identify the differences in how non V8 browser stacks are parsed. Look at the regex patterns in the current code that assume V8 format and propose changes to accommodate Firefox and Safari traces. Consider writing a small test case with sample stacks from different browsers to validate the new parser.