jenkinsci/jenkinsfile-runner

Cleanup SpotBugs warnings in the codebase

Open

#374 创建于 2020年9月30日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Java (1,090 star) (291 fork)batch import
good first issueinternal

描述

There is a number of SporBugs static analysis warnings in the old parts of the Jenkinsfile Runner codebase. It is possible to see the warnings in the build log. Although there is no severe issues, it would be great to cleanup these warnings and then enforce SpotBugs checks during the build.

List of the current SpotBugs violations: https://ci.jenkins.io/job/jenkinsfile-runner/job/jenkinsfile-runner/job/master/lastSuccessfulBuild/analysis/

Acceptance criteria:

  • All SpotBugs violations need to be either fixed or suppressed
  • FindBugs failOnError is reenabled in the pom.xml

NOTE: Contributors can submit pull requests for particular issues and issue types, no need to fix everything in a single pull request.

贡献者指南

技术栈
java
领域
backendbuild system
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
JavaMavenSpotBugs
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Examine the SpotBugs violations list at the provided URL (https://ci.jenkins.io/job/jenkinsfile runner/job/jenkinsfile runner/job/master/lastSuccessfulBuild/analysis/). For each violation, decide whether to fix the code or suppress the warning with justification. After addressing violations, reenable failOnError in pom.xml. Contributors can focus on specific violation types or areas.