jenkinsci/jenkinsfile-runner

Cleanup SpotBugs warnings in the codebase

开放

#374 创建于 2020年9月30日

 (0 条评论) (0 个反应) (0 位负责人)Java (291 个派生)batch import
good first issueinternal

仓库指标

星标
 (1,090 个星标)
PR 合并指标
 (平均合并 47天 2小时) (30 天内合并 3 个 PR)

描述

There is a number of SporBugs static analysis warnings in the old parts of the Jenkinsfile Runner codebase. It is possible to see the warnings in the build log. Although there is no severe issues, it would be great to cleanup these warnings and then enforce SpotBugs checks during the build.

List of the current SpotBugs violations: https://ci.jenkins.io/job/jenkinsfile-runner/job/jenkinsfile-runner/job/master/lastSuccessfulBuild/analysis/

Acceptance criteria:

  • All SpotBugs violations need to be either fixed or suppressed
  • FindBugs failOnError is reenabled in the pom.xml

NOTE: Contributors can submit pull requests for particular issues and issue types, no need to fix everything in a single pull request.

贡献者指南