jazzband/django-taggit

Enhacement: Add remove_by_slug() method to TaggableManager

Open

#151 创建于 2013年8月23日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Python (3,433 star) (624 fork)user submission
enhancementgood first issue

描述

That way it would also be possible to remove tags by providing their unique slugs. Have in mind that people might want to use URLs like .../some-object/tags/my-precious-tag/remove/ to remove a tag.

Adding this method seems easy, but I am reluctant to contribute a PR because I am not sure if I can write correct tests for this code addition. If some guidance and supervision is provided I am willing to try.

贡献者指南

技术栈
pythondjango
领域
backend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
PythonDjangodjango taggitDjango testing
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
The proposed method `remove by slug()` should be added to `TaggableManager` in `taggit/managers.py`. The existing `remove()` method can serve as a reference. Tests should be added in `taggit/tests.py` following patterns of existing test methods. The author expressed uncertainty about tests, so reviewing test structure and asking for maintainer clarification on expected behavior might be necessary.