jaredpalmer/after.js

Razzle as dev dependency?

开放

#419 创建于 2021年1月10日

 (5 条评论) (4 个反应) (0 位负责人)TypeScript (195 个派生)github user discovery
after.jsgood first issue

仓库指标

星标
 (4,090 个星标)
PR 合并指标
 (30 天内没有已合并 PR)

描述

🚀 Feature request

All Razzle examples use Razzle package as dev dependency. Except AfterJS - it needs Razzle as regular dependency because of razzle-dev-utils.

Current Behavior

If Razzle stays as a dev dep, I get this error message in production build:

Error: Cannot find module 'razzle-dev-utils/logger'
 Require stack:
 -  /app/node_modules/@jaredpalmer/after/build/cjs/getAssets.js
 - /app/node_modules/@jaredpalmer/after/build/cjs/render.js
 - /app/node_modules/@jaredpalmer/after/build/cjs/index.js

Desired Behavior

I would like to add AfterJS to my Razzle based project without moving Razzle from dev to regular dependencies.

Suggested Solution

Is using razzle-dev-utils in AfterJS worth? Can it be replaced with something?

贡献者指南