jantimon/favicons-webpack-plugin

Make sure examples work

Open

#295 创建于 2022年1月9日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (1,198 star) (226 fork)batch import
help wantedwontfix

描述

Is your feature request related to a problem? Please describe. I downloaded the repo, installed Node.js v10.20.0, and installed dependencies. Then I went to the basic example and ran pnpx webpack serve, and it resulted in an error (probably because there is an old version of webpack-dev-server?).

Describe the solution you'd like The examples should include dependencies like webpack, webpack-cli, and webpack-dev-server, and have scripts in package.json for starting server and building. They should also work with any node version >= the minimum node version.

Describe alternatives you've considered Using the favicon option in HtmlWebpackPlugin.

Additional context I'm using nodist and pnpm on Windows 10.

贡献者指南

技术栈
javascriptnodejs
领域
documentationdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Node.jsnpm or pnpmwebpack basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
Examine the examples directory structure in the repository. Each example likely has its own package.json that may be missing dependencies like webpack, webpack cli, and webpack dev server. Add these dependencies and create scripts for 'start' and 'build' using webpack commands. Ensure compatibility with Node.js versions >= the project's minimum. Verify the examples run successfully after changes.