jakearchibald/svgomg

Revisit `setTimeout` usage/JS animations

Open

#332 创建于 2021年9月29日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (5,473 star) (474 fork)batch import
enhancementhelp wanted

描述

There are known performance issues with setTimeout. IIRC requestAnimationFrame should behave better.

I notice junky settings checkboxes animation on Firefox for Android when Power Saving is enabled on the device. Not sure it's related, but it would probably be better to use rAF anyway?

EDIT: we are also using offsetLeft is ripple. Not sure if there's a better way to do the same thing nowadays.

贡献者指南

技术栈
javascriptcss
领域
frontendperformance
议题类型
performance
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
basic JavaScriptunderstanding of requestAnimationFrame
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Search the codebase for all uses of setTimeout, especially in animation related code. Replace them with requestAnimationFrame to improve performance. Additionally, review the ripple effect implementation that uses offsetLeft and consider modern alternatives like getBoundingClientRect or CSS transforms. The issue does not specify files, so start by examining JavaScript files handling animations or UI interactions.