jaegertracing/jaeger

Improve unit test speed

已关闭

#6,111 创建于 2024年10月22日

 (25 条评论) (0 个反应) (0 位负责人)Go (2,326 个派生)batch import
good first issuehelp wantedperformance

仓库指标

星标
 (18,974 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

This blog post provides a good background / introduction: https://threedots.tech/post/go-test-parallelism/

When I ran the following command

GOMAXPROCS=1 go test -parallel 128 -p 16 -json ./... | go run github.com/roblaszczak/vgt@latest

I got the following output:

Image

It shows some tests running for a very long time (the darker blue colors), but even of some of them were sped up there are others (like in the first group in top left corner) that are still relatively long.

We also almost never use t.Parallel() in our test (right now I only found one instance), even though many of our tests are starting servers and making network calls, so could benefit from parallelism. But adding t.Parallel() should be done with care - some tests are starting servers on the same port (instead of ephemeral port) and must be refactored before adding parallelism.

贡献者指南