jaegertracing/jaeger

Enable more revive linter rules

Open

#5,506 创建于 2024年6月2日

在 GitHub 查看
 (25 评论) (0 反应) (0 负责人)Go (18,974 star) (2,326 fork)batch import
good first issuehelp wanted

描述

In #5505 we introduced a revive linter, but had to disable many of its rules because they were breaking on some places in the code. https://github.com/jaegertracing/jaeger/blob/b38d2f9bc18806b6e716f6f666a786f0aca7d912/.golangci.yml#L154

We can re-enable those rules incrementally by fixing the corresponding breaks one rule at a time (make lint should succeed) and removing the disabling entry from the config.

Strong advice: DO NOT OPEN A PR without discussing the impact of the specific linter on this issue first. We don't want very possible linter - some of them are stupid, others require a lot of code changes with minimal benefits.

贡献者指南

技术栈
go
领域
build systemci cddeveloper experience
议题类型
chore
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
over 1 week
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Go programmingfamiliarity with revive linterunderstanding of Jaeger codebase
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Start by examining the disabled revive linter rules in the .golangci.yml file (line 154). Choose one rule, understand why it fails by running `make lint`, and propose a fix in the issue discussion. After maintainer approval, implement the fix and update the config to re enable the rule.