itzg/minecraft-server-charts

Missing values in helm templates

Open

#141 创建于 2023年1月24日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)Mustache (165 fork)github user discovery
good first issuehelp wanted

仓库指标

Star
 (391 star)
PR 合并指标
 (PR 指标待抓取)

描述

In the helm chart, two values are missing, as previously added in Minecraft bedrock. https://github.com/itzg/docker-minecraft-bedrock-server/blob/ab51be217cf5f245fcb3239466f145af3a9422ba/property-definitions.json#L112

https://github.com/itzg/docker-minecraft-bedrock-server/blob/ab51be217cf5f245fcb3239466f145af3a9422ba/property-definitions.json#L116

I did not find those two values can be easily controlled in the helm chart values.

  "emit-server-telemetry": {
    "env": "EMIT_SERVER_TELEMETRY",
    "allowed": ["true","false"]
  },
  "enable-lan-visibility": {
    "env": "ENABLE_LAN_VISIBILITY",
    "allowed": ["true","false"]
  }

I expect this feature can be added.

贡献者指南