ipfs/kubo

canonical method for checking locality of a block via coreAPI

Open

#6,726 创建于 2019年10月24日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)Go (13,906 star) (2,725 fork)batch import
help wantedkind/enhancement

描述

Location

:wave: 👨‍👧‍👧! I'm looking for the best way to ask "hey is this block local"?

Given that we're in IPFS user land, we should be using core API for this stuff. Which means we're trying to do stuff that's easiest accomplished with a blockstore via coreapi.

Blockstore method that works exactly as we'd like:

https://github.com/ipfs/go-ipfs-blockstore/blob/3eee0dff760dea94c59381e9a18b9aa290361b28/blockstore.go#L36

Relevant coreAPI subsystem:

https://github.com/ipfs/interface-go-ipfs-core/blob/1c94e6217184ed07abab840143aa1f417e314c3d/block.go#L20-L37

Description

We also have the same question about complete DAGs, happy to file a separate issue if you'd prefer. I'd love to be pointed to the canonical methods of determining if a block or dag is local via core API.

Thanks!

贡献者指南

技术栈
go
领域
apibackend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
GoIPFS core APIblockstore
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue asks for a canonical way to check if a block is local using the core API. The user points to the blockstore.Has method and the coreAPI block subsystem. To resolve, first examine the existing coreAPI block methods (see interface go ipfs core/block.go) and determine if there is already a method to check locality. If not, propose adding a method such as `IsLocal` or `Has` to the coreAPI block interface, and implement it in the Kubo repo. Also consider the question about complete DAGs. Reference the blockstore interface and ensure the new method uses it internally.