ipfs/kubo

The connection manager should treat LAN connection specially

Open

#6,130 创建于 2019年3月26日

在 GitHub 查看
 (6 评论) (4 反应) (0 负责人)Go (13,906 star) (2,725 fork)batch import
help wantedkind/enhancementneed/analysisneed/community-input

描述

Version information:

go-ipfs version: 0.4.19

Type: enhancement

Description:

The connection manager currently treat indistinctly LAN and internet connection, even though they don't have the same cost, for all meaning of this term.

This means that a MDNS-enabled node might have its LAN connection dropped when the connection manager reach the high water mark, and be forced later to route through the internet for something that could be achievable locally, which is a bit silly. Also, nodes that are in the same local network usually are mode likely to require content from each others, be it because they are part of the same application or because users want to access the same content from different machine at home.

I'd like to suggest a smarter connection manager, that either:

  • don't drop local connection
  • treat specially local connections, with a dedicated low/high water mark

贡献者指南

技术栈
go
领域
backendinfrastructure
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go programmingIPFS basicsNetworking fundamentals
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Examine the connection manager implementation in the go ipfs codebase, likely in the 'core' or 'p2p' packages. The issue suggests two approaches: preventing dropping of LAN connections or using separate watermarks. Review existing logic for peer tagging (e.g., 'connmgr' package) and explore how to differentiate LAN peers (e.g., using private IP ranges). Consider the impact on MDNS discovery and existing tests.