ipfs/kubo
在 GitHub 查看namesys/routing.go imports dht package preventing dht.Quorum() from being used with a custom routing option
Open
#5,957 创建于 2019年1月30日
P3effort/hoursexp/intermediatehelp wantedstatus/ready
仓库指标
- Star
- (13,906 star)
- PR 合并指标
- (平均合并 4天 2小时) (30 天内合并 28 个 PR)
描述
If a user is using a custom routing option (like for example, we are using a modified DHT in openbazaar) and they pass in a DhtRecordCount to namesys.Resolve. The routing resolver will call dht.Quorum(int(options.DhtRecordCount)) however, the dht package imported by routing.go is the native dht package and not the one set by the user. The quorum function doesn't apply the option to the custom routing option.
func Quorum(n int) ropts.Option {
return func(opts *ropts.Options) error {
if opts.Other == nil {
opts.Other = make(map[interface{}]interface{}, 1)
}
opts.Other[quorumOptionKey{}] = n
return nil
}
}
I think the issue using a struct defined inside the package for quorumOptionKey rather than, say, a string.