ipfs/kubo

`ipfs stats bw` doesn't support --enc json

Open

#5,594 创建于 2018年10月12日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)Go (13,906 star) (2,725 fork)batch import
P3effort/daysexp/experthelp wantedkind/bug

描述

Version information:

go-ipfs 0.4.17 and git master

Type:

Bug

Description:

All commands should support the --enc options. It doesn't work for ipfs stats bw I suppose because the result of the command is formatted in a PostRun instead of an Encoders.

贡献者指南

技术栈
go
领域
cli
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go programmingIPFS codebase familiarityCLI command structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate how other commands implement the ` enc` flag for JSON output. Look at the command definition for `stats bw` in the codebase, likely in `core/commands/` directory. The issue mentions the result is formatted in a `PostRun` instead of using an `Encoders`, so examine the `PostRun` function for `stats bw` and compare with commands that support ` enc` (e.g., `ipfs files ls`). Also check if there is an encoder registration missing. Consider adding the encoder or refactoring to use the standard encoder pattern.
`ipfs stats bw` doesn't support --enc json · ipfs/kubo#5594 | Good First Issue