`ipfs key rm` & `ipfs name publish` error out on empty stdin rather than doing nothing · ipfs/kubo#4904

(1 评论) (0 反应) (0 负责人)Go (13,906 star) (2,725 fork)batch import

help wantedkind/enhancementtopic/commands

描述

Version information:

go-ipfs version: 0.4.13- Repo version: 6 System version: amd64/linux Golang version: go1.9.4

Type:

Bug

Description:

ipfs key rm and ipfs name publish (and probably other ipfs commands) will, if invoked with no positional arguments, expect input from stdin, presumably so you can pipe in the output of other ipfs commands without needing to faff around with xargs.

The problem is that when input is empty, these commands fail:

$ ipfs name publish </dev/null
ipfs: Reading from /dev/stdin; send Ctrl-d to stop.
Error: invalid 'ipfs ref' path
$ ipfs key rm </dev/null
ipfs: Reading from /dev/stdin; send Ctrl-d to stop.
Error: invalid 'ipfs ref' path

Which is a problem when (as is often the case) the command generating the input may legitimately produce empty input, e.g. ipfs key list | grep remove-me | ipfs key rm.

贡献者指南

技术栈: go
领域: clibackend
议题类型: bug
难度: 3
预计时间: under 1 hour
活动状态: stale
清晰度: clear
前置要求: Go programmingIPFS CLI basics
新手友好度: 70
研究方向: Investigate the stdin reading logic in the `key rm` and `name publish` commands. The issue occurs when stdin is empty; the commands should handle this by doing nothing. Look at the code in the `core/commands/` directory, specifically `key.go` and `name.go` files. The fix should check if stdin has any input before attempting to parse, and if not, exit without error.