ipfs/ipfs-desktop

Improve Test Suite

Open

#1,121 创建于 2019年9月13日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (912 fork)batch import
P2effort/daysexp/intermediatehelp wantedkind/maintenance

仓库指标

Star
 (5,632 star)
PR 合并指标
 (平均合并 8天 12小时) (30 天内合并 6 个 PR)

描述

Right now, we have quite a few unit tests and some end-to-end tests for the launching process. We should aim to improve this and get a better coverage of the code.

Unit Tests

We are aiming for one unit test file per file. The biggest issue with unit tests is the amount of mocking we need to do to make sure we don't have side-effects.

E2E

We are using Spectron for our end-to-end tests and it can sometimes be limiting since we have a menubar application and Spectron does not allow to test menus.

Some interesting E2E tests that we should aim to make (if possible):

  • Test menubar interaction.
  • Test global shortcuts functionality.
  • Test adding ipfs to PATH.
  • Test Protocol Handlers (macOS and Windows only).

贡献者指南