iodide-project/iodide

Binary dragged & dropped files should not be fetched as text by default

Open

#2,456 创建于 2019年11月19日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)JavaScript (1,483 star) (147 fork)batch import
good first issuehelp wanted

描述

Steps to reproduce:

  • drag & drop a binary file into iodide main page (e.g. an excel file called Furniture_only.xls)

Expected:

%% fetch
blob: file0=Furniture_only.xls

Got:

%% fetch
text: file0=Furniture_only.xls

It is still a pain to do something with the excel file (#2447) but the fact that we're fetching the file as text is yet another roadblock. Perhaps we could sniff the type of the uploaded file and then set this property of the created notebook accordingly? @hamilton / @openjck any thoughts on this?

贡献者指南

技术栈
javascripthtmlcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
File APIMIME type detectionIodide notebook format
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Examine the drag and drop event handlers in the iodide frontend to find where the fetch command is generated. Modify the code to detect binary file MIME types and use 'blob' instead of 'text' for those files. Refer to the existing file handling logic in the repository.