iodide-project/iodide

EXPLORE/REPORT button should just be one instance of one component

Open

#1,673 创建于 2019年3月26日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)JavaScript (1,483 star) (147 fork)batch import
UI appearancebugclient UXgood first issue

描述

the explore/report button is currently actually two components. it should really just be one component that toggles its text+appearance, because it's conceptually just one thing, and not moving it during the transition will also fix a tooltip bug

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
React component basicsunderstanding of button's usage
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Locate the two separate components for the explore and report buttons, likely in the components directory. Consolidate them into a single component with a prop to toggle text and appearance. Ensure the tooltip bug (mentioned as caused by moving the button) is fixed by keeping the same DOM element. Review the 3 existing comments for any additional context or requirements.
EXPLORE/REPORT button should just be one instance of one component · iodide-project/iodide#1673 | Good First Issue