internetarchive/openlibrary

Footer external links should open in a new tab

已关闭

#13,057 创建于 2026年6月29日

 (3 条评论) (0 个反应) (0 位负责人)Python (1,959 个派生)batch import
Good First IssueLead: @mekarpelesNeeds: LeadNeeds: ResponseNeeds: TriagePriority: 4Type: Bug

仓库指标

星标
 (6,612 个星标)
PR 合并指标
 (平均合并 6天 2小时) (30 天内合并 126 个 PR)

描述

Problem

All external links in the footer open in the same tab instead of a new tab.

https://github.com/user-attachments/assets/67843849-e04c-4cdb-ab85-7be337966488

Affected file: openlibrary/templates/lib/nav_foot.html

Affected links:

  • Bluesky, X (Twitter), GitHub social icons
  • Careers (archive.org)
  • Blog (blog.openlibrary.org)
  • Terms of Service (archive.org)
  • Donate (archive.org)
  • Writing Bots (docs.openlibrary.org)
  • Release Notes (github.com)

Reproducing the bug

  1. Go to https://openlibrary.org
  2. Scroll down to the footer
  3. Click any external link (e.g. Bluesky, GitHub, Blog, Careers)
  • Expected behavior: External links should open in a new tab (target="_blank" rel="noopener noreferrer")
  • Actual behavior: External links open in the same tab, navigating the user away from Open Library

Context

  • Browser : Chrome
  • OS : Mac
  • Logged in (Y/N): Y
  • Environment : prod

Breakdown

All external links in the footer open in the same tab instead of a new tab.

https://openlibrary.org (scroll to footer)

Affected file: openlibrary/templates/lib/nav_foot.html

Affected links:

  • Bluesky, X (Twitter), GitHub social icons
  • Careers (archive.org)
  • Blog (blog.openlibrary.org)
  • Terms of Service (archive.org)
  • Donate (archive.org)
  • Writing Bots (docs.openlibrary.org)
  • Release Notes (github.com)
  1. Go to https://openlibrary.org
  2. Scroll down to the footer
  3. Click any external link (e.g. Bluesky, GitHub, Blog, Careers)
  • Expected behavior: External links should open in a new tab (target="_blank" rel="noopener noreferrer")
  • Actual behavior: External links open in the same tab, navigating the user away from Open Library

Overview

Add target="_blank" rel="noopener noreferrer" to all external anchor tags in the footer template.

Requirements Checklist

  • Add target="_blank" rel="noopener noreferrer" to all external links in nav_foot.html

Related files

  • openlibrary/templates/lib/nav_foot.html

Stakeholders

贡献者指南