Do not add parenthesis when completing methods in closures · intellij-rust/intellij-rust#4450

(0 评论) (1 反应) (0 负责人)Kotlin (4,526 star) (376 fork)batch import

E-easybughelp wantedsubsystem::сompletion

描述

Rust allows omitting closure parameters and use functions in closures directly:

fn multiply_by_two(input: i32) -> i32 {
    input * 2
}

fn main() {
    let _ = Some(5).map(multiply_by_two);
}

When I try co compete such method, I get extra parenthesis added which breaks compilation.

fn multiply_by_two(input: i32) -> i32 {
    input * 2
}

fn main() {
    let _ = Some(5).map(mul/*caret*/);
}

Then I press tab and expect to get the example above. Instead I get:

fn multiply_by_two(input: i32) -> i32 {
    input * 2
}

fn main() {
    let _ = Some(5).map(multiply_by_two(/*caret*/));
}

技术栈: kotlinrust
领域: toolingdeveloper experience
议题类型: bug
难度: 3
预计时间: half day
活动状态: stale
清晰度: clear
前置要求: IntelliJ plugin developmentRust syntaxCompletion provider API
新手友好度: 60
研究方向: The issue is about the completion behavior when completing a function name inside a closure argument. The plugin currently adds parentheses after the function name, but in Rust closures, functions can be passed directly without parentheses. The fix likely involves modifying the completion logic in the Rust completion provider (e.g., `RsCompletionContributor` or similar) to detect when the completion is inside a closure argument and omit parentheses. No existing PRs or comments are attached, so the fix should be straightforward by checking the parent context of the completion position.