influxdata/telegraf

Feature request: custom arguments to pgrep for procstat

Open

#2,505 创建于 2017年3月7日

在 GitHub 查看
 (4 评论) (2 反应) (0 负责人)Go (9,892 star) (4,161 fork)batch import
area/procstathelp wantedsize/m

描述

Proposal:

For advanced use cases, it would be nice to be able to provide custom arguments to the pgrep command used by the procstat input plugin.

Current behavior:

No such option

Desired behavior:

[[inputs.procstat]]
  pgrep = ["-w","-x","foo"]

Use case: [Why is this important (helps with prioritizing requests)]

In my specific use case, and in the example I gave above, we want -w so that we can monitor threads. We also need -x so that pgrep doesn't erroneously match the wrong process. The -x is just a nicety though, and we can match other ways. The important bit which we have no workaround for is the -w. But a generic way to provide custom arguments makes it more flexible so users can do whatever they want.

Ref: #1828 #1723 #932

贡献者指南

技术栈
go
领域
observability
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go programmingTelegraf plugin developmentpgrep command
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Start by examining the procstat plugin located in plugins/inputs/procstat/. Look at how other input plugins handle custom configuration options. The issue requests adding a 'pgrep' config option that accepts an array of strings. Consider implementing a function that splits the array and passes them to the pgrep command. Check the existing config parsing in agent/config.go for pattern. Also review linked issues #1828, #1723, and #932 for prior discussions.
Feature request: custom arguments to pgrep for procstat · influxdata/telegraf#2505 | Good First Issue