infinitered/ignite

Dark mode support in splash-screen generator

Open

#2,855 创建于 2024年11月25日

在 GitHub 查看
 (3 评论) (0 反应) (2 负责人)TypeScript (1,342 fork)batch import
enhancementhelp wanted

仓库指标

Star
 (16,168 star)
PR 合并指标
 (30 天内没有已合并 PR)

描述

I'd like to be able to generate the assets for a dark mode splash screen along side the "normal" light mode assets.

Currently, I can call npx ignite-cli generate splash-screen and the generator will read logo.png from ignite/templates/splash-screen and output the necessary assets to assets/images. That will work whether logo.png is the image I want to use for light mode or dark mode. The trouble is that if I do one it will overwrite the other and vice versa. I'd like to be able to generate both sets of assets at the same time so I can reference them from my expo app.json

I suggest adding a --dark parameter that would tell the generate to read logo-dark.png, output assets that start with "splash-logo-dark" instead of "splash-logo," and update app.json accordingly. But there might be other possible solutions.

I'm happy to take a shot at adding this myself and sending a PR. But I thought it would be wise to make sure something like this wasn't already in the works. And that the solution I suggested above is a valid design.

Thanks!

贡献者指南