import-js/eslint-plugin-import

[no-duplicates] prefer-inline breaks unassigned and top-level type imports

Open

#3,130 创建于 2024年12月23日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)JavaScript (4,946 star) (1,540 fork)batch import
bughelp wantedtypescript

描述

"import/no-duplicates": ["error", { "prefer-inline": true }],

Will detect an error in the following typescript code:

import type { X } from "xyz";

import "xyz";

// [...]

It will auto-fix by removing the import "xyz"; statement. This is not the desired behavior. I would expect it to stay as is.

Merry Christmas 🎄

贡献者指南

技术栈
typescriptjavascript
领域
developer experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of TypeScript import typesBasic knowledge of ESLint rules
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
The issue is about the `no duplicates` rule with `prefer inline` option incorrectly removing a side effect import when a type import from the same module exists. To fix, examine the rule's implementation in `src/rules/no duplicates.ts` (or similar) to understand how it handles `type` imports and side effect imports. The auto fix logic should preserve `import "xyz";` even when `import type { X }` is present. Look at existing tests for `prefer inline` to see how they handle edge cases and add a test case for unassigned imports. The issue reporter provided a clear failing example.