import-js/eslint-plugin-import

[import/no-duplicates] `{"prefer-inline": true}` does not work

Open

#2,715 创建于 2023年2月12日

在 GitHub 查看
 (14 评论) (13 反应) (0 负责人)JavaScript (4,946 star) (1,540 fork)batch import
bughelp wantedtypescript

描述

version 2.27.5

https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-duplicates.md#inline-type-imports The documentation states that adding {"prefer-inline": true} as shown below will cause errors and autofixes if there are duplicate imports. However, this was not possible in my environment.

{
  "import/no-duplicates": ["error", {"prefer-inline": true}],
}

It should look like the following, but there is no error or anything.

import NextErrorComponent from 'next/error';
import { type ErrorProps } from 'next/error';
// ↓
import NextErrorComponent, { type ErrorProps } from 'next/error';

image

Is this currently being corrected?

贡献者指南

技术栈
javascripttypescriptnodejs
领域
toolingdeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic ESLint configurationTypeScript import syntax
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Review the `no duplicates` rule implementation in the eslint plugin import repository, specifically how the `prefer inline` option is handled. Look at the rule's source file (likely `src/rules/no duplicates.js`) and its tests. Check if there are any existing PRs or issues addressing this. The documentation mentions inline type imports, but the actual behavior may not merge duplicate imports as expected. Focus on the logic that merges imports and how the option affects it.