import-js/eslint-plugin-import

no-unused-modules "missingExports" returns false positives

Open

#2,102 创建于 2021年5月27日

在 GitHub 查看
 (7 评论) (1 反应) (0 负责人)JavaScript (4,946 star) (1,540 fork)batch import
`exports` supportbughelp wanted

描述

I'd expect both of these cases to count as exports:

module.exports = {} // Should probably not trigger

export * from './someFile' // Should almost definitely not trigger

贡献者指南

技术栈
javascriptnodejs
领域
toolingdeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
eslintnpm module exports
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The bug is in the no unused modules rule's missingExports logic. Examine the rule's source at src/rules/no unused modules.js and its tests in tests/src/rules/no unused modules.js. The issue involves detecting exports from `module.exports = {}` and `export * from './someFile'`. Look at how the rule currently gathers exports and why these cases are missed. Check GitHub for any existing PRs or comments that discuss the detection scope. The fix likely requires modifying the export extraction to include these patterns, ensuring they are considered as exports.