import-js/eslint-plugin-import

no-extraneous-dependencies does not report when importing from subfolder

Open

#1,918 创建于 2020年10月5日

在 GitHub 查看
 (3 评论) (2 反应) (0 负责人)JavaScript (4,946 star) (1,540 fork)batch import
bughelp wanted

描述

My eslint settings:

'import/no-extraneous-dependencies': ['error', { devDependencies: ['**/*.test.js'] }],

and package.json:

    "devDependencies": {
        ...
        "uuid": "^8.3.0",
    }

The following import does not error:

const v5 = require('uuid/v5')

However it does error, when using exact package name:

const { v5 } = require('uuid')

Its quite common practice, so I believe it should complain also when referencing individual files from a package...

贡献者指南

技术栈
javascriptnodejs
领域
toolingdeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ESLint plugin developmentNode.js module resolution
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue is about the 'no extraneous dependencies' rule not flagging imports from subdirectories of devDependencies (e.g., require('uuid/v5')). The relevant source file is likely 'src/rules/no extraneous dependencies.js'. The current logic checks if the imported module name matches a package exactly, but does not handle subpath imports. The contributor should examine how the rule extracts the package name from the import specifier and extend it to also handle cases where the specifier starts with a package name followed by a slash. The comments in the issue may contain additional details. No pull requests are linked.