import-js/eslint-plugin-import

[import/newline-after-import] false positive with typescript import = require

Open

#1,654 创建于 2020年2月11日

在 GitHub 查看
 (5 评论) (1 反应) (0 负责人)JavaScript (4,946 star) (1,540 fork)batch import
bughelp wantedtypescript

描述

When using import/newline-after-import with typescript import = require(..) I get a false positive requiring me to put a newline in the middle of the imports.

import foo from "foo";
import bar = require("bar");
import baz from "baz";

Expected results

No errors

Actual results

1:1 error Expected 1 empty line after import statement not followed by another import import/newline-after-import

贡献者指南

技术栈
javascripttypescriptnodejs
领域
developer experiencetooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ESLint plugin developmentJavaScriptTypeScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Investigate the `newline after import` rule in the eslint plugin import source code (likely in `src/rules/newline after import.js`). The rule currently does not recognize TypeScript's `import = require()` as an import statement, causing a false positive. Look for where import statements are identified via AST nodes and add support for `TSImportEqualsDeclaration` (or similar) node type. Check if there are existing tests for TypeScript and add a test case.