import-js/eslint-plugin-import

Use globbing with `no-unused-modules` options

Open

#1,326 创建于 2019年4月14日

在 GitHub 查看
 (3 评论) (1 反应) (0 负责人)JavaScript (4,946 star) (1,540 fork)batch import
enhancementhelp wantedquestion

描述

I would like to check for dead code in my test helpers using the no-unused-modules rule.

My test folder is test/ and my helpers are in test/helpers/ (which is a common setup with Ava).

The src and ignoreExports are file paths, which makes it hard to use in such a setup. Indeed I need src to target my test files + helpers (test/) but ignoreExports should exclude the test files since they do not export anything.

One possible solution would be to allow globbing in src and ignoreExports, e.g. { src: 'test/', ignoreExports: ['test/', '!test/helpers'] }. What do you think?

贡献者指南

技术栈
javascriptnodejs
领域
toolingdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptESLint plugin developmentglob patterns
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Look at the rule implementation in `rules/no unused modules.js`. Understand how `src` and `ignoreExports` options are currently processed. Implement glob support by integrating a library like `minimatch` or `glob`, update option validation, and add tests for the new behavior. Check existing test patterns for inspiration.