import-js/eslint-plugin-import

regression: no-extraneous-dependencies when lint target file in a module sub-folder containing package.json

Open

#1,270 创建于 2019年1月25日

在 GitHub 查看
 (2 评论) (1 反应) (0 负责人)JavaScript (4,946 star) (1,540 fork)batch import
bughelp wanted

描述

Using node@10.15.0 on OSX. Upgraded eslint-plugin-import from 2.14.0 to 2.15.0. Have a package.json that includes numerous dependencies of the form:

"xyz": "git+ssh://git@github.home.247-inc.net:platform/xyz.git#0.0.8",

When running eslint@5.12.1 I now get errors of the following form:

error 'xyz' should be listed in the project's dependencies. Run 'npm i -S xyz' to add it import/no-extraneous-dependencies

Reverting to 2.14.0, the errors are no longer reported.

贡献者指南

技术栈
javascriptnodejs
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Node.jsESLint plugin developmentnpm package resolution
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Investigate the regression from v2.14 to v2.15 in the no extraneous dependencies rule. The issue is that git+ssh dependencies are incorrectly flagged as missing. Look at the rule source in src/rules/no extraneous dependencies.js and the module resolution utilities. Check the changelog or diff between versions to identify the relevant commit. Test with a package.json containing git dependencies to understand the parsing logic.