immutable-js/immutable-js

Use ES6 Proxies where available for indexed access on Indexed

Open

#440 创建于 2015年4月9日

在 GitHub 查看
 (20 评论) (16 反应) (0 负责人)TypeScript (33,046 star) (1,774 fork)batch import
enhancementhelp wanted

描述

list.get(index) syntax works fine some of the time but it adds up a learning curve + migration cost when you wish swap out arrays in the existing code with lists. I think it would be very nice to put the Proxy like following at the bottom of the prototype chain to allow optional access by index:

let accesor = new Proxy(Object.prototype, {
  get(target, property, receiver) {
    return receiver.get(property)
  }
});

// Workaround to monkey patch loaded immutable.js library, although it should be:
// Iterable.prototype = Object.create(accessor, {....})
Object.setPrototypeOf(Immutable.Iterable.prototype, accesor)

Immutable.List.of(1, 2, 3)[0] // => 1
Immutable.List.of(1, 2, 3)[1] // => 2
Immutable.List.of(1, 2, 3)[5] // => undefined
Immutable.List.of(1, 2, 3)[-2] // => 2

贡献者指南

技术栈
javascripttypescript
领域
developer experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptES6 ProxiesPrototype chain
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Investigate the current implementation of Indexed collections (List, Stack, etc.) in immutable js, focusing on the get method and the prototype chain. Look at files like 'src/List.js' and 'src/Iterable.js' to understand where a Proxy could be inserted. Review the existing issue comments for concerns about performance, compatibility with older browsers, and desired behavior for negative indices. Consider the approach suggested in the issue of setting the prototype of Iterable.prototype to a Proxy object, and evaluate any side effects on other parts of the library.
Use ES6 Proxies where available for indexed access on Indexed · immutable-js/immutable-js#440 | Good First Issue