idyll-lang/idyll

React lifecycle warning

Open

#711 创建于 2021年3月10日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (1,977 star) (97 fork)batch import
ComponentsGood First PRRough EdgesRuntimehelp wanted

描述

Describe the bug Some components depend on React lifecycle methods that are being deprecated, see this warning:

Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.\n

To Reproduce Create the default idyll article and look at terminal and JS console.

Expected behavior There are no warnings from React. I believe the idyll-document component relies on this method, as well as several components in idyll-components, including at least table, maybe others.

贡献者指南

技术栈
reactjavascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with ReactNode.js installed
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The error involves deprecated lifecycle methods in React, particularly componentWillReceiveProps. This occurs in the idyll document component and several components in idyll components, including at least the table component. To fix, first try running the recommended codemod: `npx react codemod rename unsafe lifecycles` from the project root. Then manually check any remaining warnings in the browser console. Focus on the src directory, especially files under packages/idyll document and packages/idyll components. Ensure all usages of the deprecated methods are renamed. There are no linked PRs or comments, so this issue is available for a first time contributor.