icesat2py/icepyx

add page size checks for sync/async request mode

开放

#243 创建于 2021年11月9日

 (2 条评论) (0 个反应) (0 位负责人)Python (119 个派生)auto 404
IS2HW_2022good first issue

仓库指标

星标
 (256 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

There's still a reference to using a smaller page size in examples/examples/ICESat-2_DAAC_DataAccess_Example.ipynb because it refers to synchronous requests. Note that this notebook indicates that synchronous requests are done by default, but I think this must be outdated. It looks like the request mode is async by default (https://github.com/icesat2py/icepyx/blob/development/icepyx/core/APIformatting.py#L446).

Given that the page size limit is only 100 when the request mode is synchronous, maybe we need another check somewhere that decreases the page size when a user overrides that default and uses synchronous mode?

Originally posted by @trey-stafford in https://github.com/icesat2py/icepyx/issues/239#issuecomment-963612931

贡献者指南