iced-rs/iced

Superfluous alignment functions

Open

#286 创建于 2020年4月11日

在 GitHub 查看
 (7 评论) (5 反应) (0 负责人)Rust (30,491 star) (1,572 fork)batch import
good first issuehelp wantedlayoutquestion

描述

The current api exposes multiple ways for alignment to be expressed:

  • Container::center_x is equivalent to Container::align_x(Center)
  • HorizonalAlignment, VerticalAlignement, and Align all express the same concept.

These introduce more names and relationships for users to learn about in the api, and I think reducing them would be positive. could we remove them?

贡献者指南

技术栈
rust
领域
frontenddeveloper experience
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Rust programmingIced API basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Review the alignment related code in the Iced codebase, specifically `Container::center x` and `Container::align x` methods and the alignment enums (`HorizontalAlignment`, `VerticalAlignment`, `Align`). Check existing tests and documentation for these functions. Consult the issue comments (#286) for any maintainer guidance on preferred approach. Implement removal or deprecation with corresponding updates to docs and changelog.
Superfluous alignment functions · iced-rs/iced#286 | Good First Issue