ianyh/Amethyst

Can't float the 'Add to Todoist' pop up in Brave Browser.

Open

#1,410 创建于 2023年2月7日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Swift (16,121 star) (516 fork)batch import
bughelp wanted

描述

Describe the bug When right clicking on a webpage and adding to Todoist the pop up always stretches to full screen in line with Amethyst settings, despite adding the title of the window (and some attempted variants) to the float settings.

Applications: Todoist & Brava Browser

To Reproduce Right click and 'Add to Todoist'

Expected behavior The pop up window floats without enlarging to full screen

Screenshots

Versions:

  • macOS:
  • Amethyst:

Debug Info

$ /Applications/Amethyst.app/Contents/MacOS/Amethyst --debug-info [--include-apps]

Note: --include-apps will list your manageable applications, but is optional if you don't want to list that.

Additional context Add any other context about the problem here.

贡献者指南

技术栈
swift
领域
desktop
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Basic understanding of Amethyst window managementFamiliarity with macOS window titlingAbility to test with Brave browser and Todoist
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate the window identification logic in Amethyst, likely in files like `Window.swift` or `Configuration.swift`. Determine how the app matches windows to float rules (e.g., by title, bundle ID, or other properties). Test with the Todoist popup in Brave to see what properties the window has, and consider if a more flexible matching or a new rule is needed. No previous PRs or comments exist for this issue.