hyperstack-org/hyperstack

a Native::Object in component params can't be retrieved

Open

#417 创建于 2021年7月16日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (531 star) (43 fork)batch import
buggood first issue

描述

A Native::Object is a BasicObject and it doesn't respond to "tap". It defines method_missing so Native::Object.new.tap returns nil

At hyperstack/ruby/hyper-component/lib/hyperstack/internal/component/props_wrapper.rb:113 .tap returns nil so fetch_from_cache returns nil instead of the Native::Object.

I suggest to rewrite fetch_from_cache without using tap.

贡献者指南

技术栈
ruby
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
RubyBasicObject
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
The issue points to the file `hyperstack/ruby/hyper component/lib/hyperstack/internal/component/props wrapper.rb` at line 113. The current implementation uses `.tap` which fails on `Native::Object` since it is a `BasicObject` that does not respond to `tap`. The fix is to rewrite the `fetch from cache` method without using `tap`, for example by storing the value in a variable and then returning it. Check the comments for any additional context or maintainer input.