hound-search/hound

`make test` fails if `db/` has contents.

Open

#363 创建于 2020年10月30日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)JavaScript (5,470 star) (606 fork)batch import
buggood first issuehelp wanted

描述

If you start the houndd server, /db becomes populated with the contents of other repos. Both jest and go test currently crawl over /db and get confused by it, usually because there are naming collisions.

I think three things would make this a little better:

  1. make clean should also empty db/.
  2. jest should ignore db/, which seems easy to do in a jest-config.js file.
  3. go test should ignore db, which seems like we have to do manually, by using something like go test 'go list ./... | grep -v directoriesToSkip\` (I got that example from stack overflow).

A band-aid could be to just do 1 above and then run it before we run tests. That doesn't seem ideal, though, because we'd have to re-install node_modules between make clean and running the tests.

贡献者指南

技术栈
javascriptgoshelljest
领域
backendtestingdevops
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go testingJest configurationMakefile basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Review the issue for proposed solutions: 1) add db/ cleanup to make clean, 2) configure jest to ignore db/ via jest.config.js or package.json, 3) modify go test command to exclude db/ (e.g., using 'go test $(go list ./... | grep v db)'). Check the repository's existing Makefile and test configuration files for integration points. Comment #2 may provide additional insights.
`make test` fails if `db/` has contents. · hound-search/hound#363 | Good First Issue