Client does not update object on response failure

描述

var resp client.Response
// finds results
err := client.Search(&resp, cfg, "node-xray", svc, "^package.json", 0, false, false)
// does not find results
err := client.Search(&resp, cfg, "http-shutdown", svc, "^package.json", 0, false, false)
// Expected Behavior - resp holds results from second call.
// Actual Behavior - resp still holding results from first call.

贡献者指南

技术栈

go

领域

backendapisearch

议题类型

bug

难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。

3

预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。

1-3 hours

活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。

stale

清晰度议题是否清楚说明期望改动、验收标准和下一步。

clear

前置要求

Go basicsHTTP client handling

新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。

65

研究方向

Examine the client.Search function in the Go client code, likely in a file like client.go. The bug is that when Search fails (returns an error), the resp object is not updated and retains the previous result. Look for early returns on error that skip updating resp. A fix should ensure resp is modified or reset even on failure, or the function should not modify resp on error but the caller expects it to hold new results only on success. Check the current implementation to understand the intended behavior and apply a minimal fix.