handshake-org/hsd

Improve test coverage

Open

#684 创建于 2022年1月11日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (1,814 star) (286 fork)batch import
Good first issuetests

描述

I noticed in the coverage report that a lot of the wallet make___() errors are not covered (eg "Auction is not yet open" and "Name has not reached bidding phase", etc). This could be another "good first issue" that would be easy to do and get a few more lines covered.

Originally posted by @pinheadmz in https://github.com/handshake-org/hsd/issues/683#issuecomment-1009248506

贡献者指南

技术栈
javascript
领域
testing
议题类型
test
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Node.jsbasic testing knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
The issue requests adding test coverage for wallet `make ()` error messages. Review the referenced comment in issue #683 for context. Locate the wallet module in the codebase, identify all error strings (e.g., 'Auction is not yet open'), and write unit tests that verify these errors are thrown correctly under relevant conditions.