handlebars-lang/handlebars.js

Typings allow calling "compile" when including "handlebars/runtime".

Open

#1,513 创建于 2019年3月16日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (17,697 star) (2,032 fork)batch import
bughelp wantedtypingsunverified

描述

This issue is actually not verified, but maybe someone can verify and fix it:

The typings of "handlebars/runtime" currently include "handlebars.d.ts", so the "compile"-method is probably part of the typings for "handlebars/runtime". This is nonsense of course. It should only be in "handlebars".

I think the inclusion should be the other way around: Most typings should be in "runtime.d.ts". "handlebars.d.ts" should include them and add "compile" and "precompile".

贡献者指南

技术栈
typescriptjavascript
领域
developer experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
TypeScripthandlebars.js type definitions structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
Examine the handlebars.d.ts and runtime.d.ts files in the repository. The fix involves moving the shared typings into runtime.d.ts and importing them in handlebars.d.ts, then adding the compile and precompile methods to handlebars.d.ts only. No linked PRs or comments provide further guidance; follow the issue description.