guardicore/monkey

Invalid configurations can be exported in the UI

开放

#3,703 创建于 2023年9月15日

 (0 条评论) (0 个反应) (0 位负责人)Python (752 个派生)batch import
BugComplexity: MediumHelp wantedImpact: LowUI

仓库指标

星标
 (6,250 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Describe the bug

While an invalid configuration can't be submitted through the UI, it can be exported.

Trying to import that configuration in the UI isn't allowed, so it could be frustrating for a user who didn't realise that some values were invalid while exporting.

To Reproduce

Steps to reproduce the behavior:

  1. Run Island
  2. Add invalid configuration value somewhere
  3. Try submitting and see warning box
  4. Export and check the exported configuration for invalid value

Expected behavior

Don't allow exporting configuration if some values are invalid.

Screenshots

  1. Added invalid IP to configuration image

  2. Export modal works normally, but a warning is shown on the configuration page image

  3. Warning box image

  4. Exported configuration image

贡献者指南