guardicore/monkey

Invalid configurations can be exported in the UI

Open

#3,703 创建于 2023年9月15日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Python (6,250 star) (752 fork)batch import
BugComplexity: MediumHelp wantedImpact: LowUI

描述

Describe the bug

While an invalid configuration can't be submitted through the UI, it can be exported.

Trying to import that configuration in the UI isn't allowed, so it could be frustrating for a user who didn't realise that some values were invalid while exporting.

To Reproduce

Steps to reproduce the behavior:

  1. Run Island
  2. Add invalid configuration value somewhere
  3. Try submitting and see warning box
  4. Export and check the exported configuration for invalid value

Expected behavior

Don't allow exporting configuration if some values are invalid.

Screenshots

  1. Added invalid IP to configuration image

  2. Export modal works normally, but a warning is shown on the configuration page image

  3. Warning box image

  4. Exported configuration image

贡献者指南

技术栈
python
领域
apibackend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
Investigate the configuration export endpoint in the backend (likely in a Python file handling configuration). Check if there is existing validation logic used during configuration submission and apply it before export. Look at the UI export component to understand the flow. The warning box suggests validation already exists; ensure it's triggered on export as well.
Invalid configurations can be exported in the UI · guardicore/monkey#3703 | Good First Issue