guardicore/monkey

Unify modal window styles

Open

#1,002 创建于 2021年2月26日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Python (6,250 star) (752 fork)batch import
Beginner friendlyComplexity: LowHelp wantedImpact: MediumUI

描述

Some modal windows have their style inlined in their JSX:

https://github.com/guardicore/monkey/blob/bc3283c4a5177c7d08ff65bb13370d061aae60d3/monkey/monkey_island/cc/ui/src/components/ui-components/IslandMonkeyRunErrorModal.js#L72-L82

https://github.com/guardicore/monkey/blob/bc3283c4a5177c7d08ff65bb13370d061aae60d3/monkey/monkey_island/cc/ui/src/components/pages/ConfigurePage.js#L178-L195

https://github.com/guardicore/monkey/blob/26dc2aeb146a50651a0df223d979a0fdf2161a5c/monkey/monkey_island/cc/ui/src/components/configuration-components/UnsafeOptionsConfirmationModal.js#L7-L27

Other modals, such as ImageModal and ScoutsuiteRuleModal have separate style sheets.

Unify the styles for all modal windows. Use style sheets instead of hardcoding style in the JSX

贡献者指南

技术栈
javascriptreactcss
领域
frontend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic React knowledgeCSS
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Identify all modal components that have inline styles in JSX. Use the provided links as starting points (e.g., IslandMonkeyRunErrorModal.js, ConfigurePage.js, UnsafeOptionsConfirmationModal.js). Extract the inline styles and create CSS modules or stylesheets for each modal. Ensure the styles are consistent with existing modal stylesheets like those in ImageModal and ScoutsuiteRuleModal. Test by running the UI and verifying the modals display correctly.