guardian/scribe

Code button in the demo not working properly

Open

#482 创建于 2016年6月9日

在 GitHub 查看
 (2 评论) (0 反应) (1 负责人)JavaScript (3,516 star) (265 fork)batch import
bughelp wanted

描述

Hi Guardian team!

Using Chrome 51 on Windows.

When I try your current demo, the Code button is not working correctly. It is like the editor did't recognize that some text was already wrapped in <code>, so it keeps wrapping it over and over instead of removing the code formatting after second click.

How to reproduce:

  1. Open the demo
  2. Select the word World
  3. Press Code button
  4. Press Code button again

Expected: The selected word would be wrapped in <code> and then unwrapped. Actual: The selected word is wrapped twice (<code><code>World</code></code>)

贡献者指南

技术栈
javascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic JavaScriptunderstanding of rich text editing
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Examine the code button handler in the Scribe editor source. The issue is that toggling code formatting does not correctly detect existing `<code>` wrappers, causing nested wrapping. Look for the function that toggles code formatting, likely in the `scribe.js` or a plugin file. Check if there are existing tests for the code button to understand the expected behavior. The assigned user may have a fix in progress; check the assignee's branch or linked work.