guardian/scribe

Make sure scribe markers are not left around

Open

#278 创建于 2014年10月24日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (3,516 star) (265 fork)batch import
beginnerhelp wanted

描述

Scribe markers are currently left all over the place. Look at this https://github.com/guardian/scribe/pull/248 for an example.

The approach here from @chanon is simple but should be merged as part of a separate pull request as checking the range was done in https://github.com/guardian/scribe/pull/273

贡献者指南

技术栈
javascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
needs investigation
前置要求
basic understanding of Scribefamiliarity with DOM range
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
First, review the linked PR #248 to understand the approach suggested by chanon. Then, examine the current state of scribe markers in the source code, particularly in the relevant module (likely the selection or range handling). Check PR #273 for the range checking work that was done. The fix likely involves ensuring that when a selection or range is applied, any temporary markers are cleaned up. Since the repo is deprecated, consider if the issue is still relevant.
Make sure scribe markers are not left around · guardian/scribe#278 | Good First Issue