guardian/scribe

`underline` command is "enabled" when cursor is inside an <a> link

Open

#206 创建于 2014年6月20日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (3,516 star) (265 fork)batch import
browser inconsistencybughelp wantedpatch needed

描述

It seems like the default "underline" command checks the enabled CSS of the current selection, rather than looking for an explicit <u> element.

We were able to fix this locally easily by overriding the default "underline" queryState() command to look for an explicit <u> tag instead of relying on the default behavior.

贡献者指南

技术栈
javascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic JavaScriptunderstanding of DOM events
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Examine the default underline command's `queryState()` method in Scribe's source code (likely in `underline.js` or similar). The issue indicates it checks CSS `enabled` instead of looking for an explicit `<u>` element. The fix involves overriding that method to detect `<u>` tags. Review the existing override pattern in the codebase to ensure consistency.