guardian/scribe

Scribe transactionManager assumes that selection is always inside an editor

Open

#153 创建于 2014年5月2日

在 GitHub 查看
 (10 评论) (0 反应) (0 负责人)JavaScript (265 fork)batch import
bughelp wanted

仓库指标

Star
 (3,516 star)
PR 合并指标
 (30 天内没有已合并 PR)

描述

Scribe transactionManager assumes that selection is always inside an editor, but this can be wrong. I discovered issues because Scribe was modifying DOM outside editor.

We have the following scenario. User selects text outside the editor and based on that selection we prepopulate editor's content (I simply call jQuery .html(...) on the editor to set the content – should I use something else?). The issue is that as I prepopulate editor's content, mutation observer is triggered which calls transactionManager. And transaction manager calls:

var selection = new this.api.Selection();
selection.placeMarkers();

This places <em/> tags where selection is. But selection is outside the editor, not inside.

I think that code should check if selection is inside the editor element our outside.

贡献者指南